lkml.org 
[lkml]   [2008]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/26] atl1: refactor tx processing
    Jay Cliburn wrote:
    > On Tue, 22 Jan 2008 18:31:09 -0600
    > Jay Cliburn <jacliburn@bellsouth.net> wrote:
    >
    >> On Tue, 22 Jan 2008 04:58:17 -0500
    >> Jeff Garzik <jeff@garzik.org> wrote:
    >>
    > [...]
    >>> for such a huge patch, this description is very tiny. [describe]
    >>> what is refactored, and why.
    >
    > Is this one any better?

    This satisfies me.

    Acked-by: Chris Snook <csnook@redhat.com>

    > From df475e2eea401f9dc18ca23dab538b99fb9e710c Mon Sep 17 00:00:00 2001
    > From: Jay Cliburn <jacliburn@bellsouth.net>
    > Date: Wed, 23 Jan 2008 21:36:36 -0600
    > Subject: [PATCH] atl1: simplify tx packet descriptor
    >
    > The transmit packet descriptor consists of four 32-bit words, with word 3
    > upper bits overloaded depending upon the condition of its bits 3 and 4.
    > The driver currently duplicates all word 2 and some word 3 register bit
    > definitions unnecessarily and also uses a set of nested structures in its
    > definition of the TPD without good cause. This patch adds a lengthy
    > comment describing the TPD, eliminates duplicate TPD bit definitions,
    > and simplifies the TPD structure itself. It also expands the TSO check
    > to correctly handle custom checksum versus TSO processing using the revised
    > TPD definitions. Finally, shorten some variable names in the transmit
    > processing path to reduce line lengths, rename some variables to better
    > describe their purpose (e.g., nseg versus m), and add a comment or two
    > to better describe what the code is doing.
    >
    > Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>


    \
     
     \ /
      Last update: 2008-01-25 02:11    [W:0.021 / U:1.432 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site