lkml.org 
[lkml]   [2008]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] bfs: move function prototype to the proper header file
Ooops, I didn't look at the _name_ of the function, i.e. it being 
dump_imap(), an internal helper --- of course it shouldn't be extern'd you
are right :)

On Thu, 24 Jan 2008, Tigran Aivazian wrote:

> On Fri, 25 Jan 2008, Heikki Orsila wrote:
>> On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote:
>>> diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
>>> index 090b96e..ecc74bb 100644
>>> --- a/fs/bfs/bfs.h
>>> +++ b/fs/bfs/bfs.h
>> ...
>>> +/* inode.c */
>>> +extern void dump_imap(const char *, struct super_block *);
>>> +
>>
>> Functions should not be externed, remove extern keyword.
>
> why not?
>
> In (roughly, because ^extern pattern is not ideal) 3959 cases only in
> include/linux/*h they are:
>
> $ grep ^extern include/linux/*h | wc -l
> 3959
>
> Kind regards
> Tigran
>


\
 
 \ /
  Last update: 2008-01-25 00:19    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site