Messages in this thread | | | Date | Fri, 25 Jan 2008 02:13:00 +0300 | From | Dmitri Vorobiev <> | Subject | Re: [PATCH 5/9] bfs: move function prototype to the proper header file |
| |
Heikki Orsila пишет: > On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote: >> diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h >> index 090b96e..ecc74bb 100644 >> --- a/fs/bfs/bfs.h >> +++ b/fs/bfs/bfs.h > ... >> +/* inode.c */ >> +extern void dump_imap(const char *, struct super_block *); >> + > > Functions should not be externed, remove extern keyword. >
Care to explain why?
Following is an explanation why the contrary is probably true:
1) We have lots of precedents in existing code:
dmvo@cipher:~/Projects/misc/linux$ git-grep 'extern void' include | wc -l 5523 dmvo@cipher:~/Projects/misc/linux$
2) Linus' Coding style does not mandate what you requested.
3) The checkpatch.pl did not complain at this particular patch.
Thanks,
Dmitri
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |