Messages in this thread | | | Date | Wed, 23 Jan 2008 23:55:31 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH -mm] fix variable use in AVR32 pte_alloc_one |
| |
> On Wed, 23 Jan 2008 13:20:10 +0100 Haavard Skinnemoen <hskinnemoen@atmel.com> wrote: > On Wed, 23 Jan 2008 22:57:34 +1100 > Ben Nizette <bn@niasdigital.com> wrote: > > > > > Some parts of this function use 'page', some 'pte'. As such, an AVR32 > > -mm build fails with an undefined reference to 'page'. > > > > Signed-Off-By: Ben Nizette <bn@niasdigital.com> > > > > --- > > Index: linux-2.6.24-rc8-mm1/include/asm-avr32/pgalloc.h > > =================================================================== > > --- linux-2.6.24-rc8-mm1.orig/include/asm-avr32/pgalloc.h > > +++ linux-2.6.24-rc8-mm1/include/asm-avr32/pgalloc.h > > @@ -52,9 +52,9 @@ static inline struct page *pte_alloc_one > > struct page *pte; > > > > pte = alloc_page(GFP_KERNEL | __GFP_REPEAT | __GFP_ZERO); > > - if (!page) > > + if (!pte) > > return NULL; > > - pgtable_page_ctor(page); > > + pgtable_page_ctor(pte); > > return pte; > > } > > Hmm...I can't see anything like this on my current avr32-arch branch, > but I think I mistakenly pushed out some unfinished code about a week > ago and rewound it shortly afterwards. If Andrew pulled during that > window, I guess it must have made it into -mm :-( > > But thanks for testing and for providing a fix. I'll check the code > that I was working on and apply the patch if it's still broken. >
This bustage was added by the -mm-only config_highpte-vs-sub-page-page-tables.patch
Thanks for the fix.
| |