Messages in this thread | | | Subject | Re: [PATCH 24/27] NFS: Use local caching [try #2] | From | Trond Myklebust <> | Date | Thu, 24 Jan 2008 16:08:34 -0500 |
| |
On Wed, 2008-01-23 at 17:22 +0000, David Howells wrote: > The attached patch makes it possible for the NFS filesystem to make use of the > network filesystem local caching service (FS-Cache). > > To be able to use this, an updated mount program is required. This can be > obtained from: > > http://people.redhat.com/steved/fscache/util-linux/ > > To mount an NFS filesystem to use caching, add an "fsc" option to the mount: > > mount warthog:/ /a -o fsc
Nope. The new text-based mount code should just work. There should be no need to also support cachefs via the legacy binary formant.
> Signed-off-by: David Howells <dhowells@redhat.com> > --- > > fs/nfs/Makefile | 1 > fs/nfs/client.c | 5 + > fs/nfs/file.c | 37 ++++ > fs/nfs/fscache-def.c | 289 +++++++++++++++++++++++++++++++++ > fs/nfs/fscache.c | 391 +++++++++++++++++++++++++++++++++++++++++++++ > fs/nfs/fscache.h | 148 +++++++++++++++++ > fs/nfs/inode.c | 47 +++++ > fs/nfs/read.c | 28 +++ > fs/nfs/super.c | 3 > fs/nfs/sysctl.c | 1 > include/linux/nfs_fs.h | 9 + > include/linux/nfs_fs_sb.h | 18 ++ > 12 files changed, 968 insertions(+), 9 deletions(-) > create mode 100644 fs/nfs/fscache-def.c > create mode 100644 fs/nfs/fscache.c > create mode 100644 fs/nfs/fscache.h >
This needs to be split up.
Scheduling an fscache write, retrieving pages from fscache, managing fscache cache consistency, adding statistics are all examples of completely separate tasks that should not be bunched together in a single megapatch, particularly not since they touch core NFS code.
Trond
| |