lkml.org 
[lkml]   [2008]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: fix?unconditional?arch/x86/kernel/pcspeaker.c?compiling
    On Wed, Jan 23, 2008 at 11:30:11PM +0100, Michael Opdenacker wrote:
    > On Friday 18 January 2008, Matt Mackall wrote:
    > >
    > > Probably makes sense to define it right next to INPUT_PCSPKR in
    > > drivers/input/Kconfig.
    > >
    > > Then do the appropriate fix for all arches mentioned in INPUT_PCSPKR.
    > >
    > > For extra points, you can move the duplicate pcspeaker.c code out of all
    > > those arches and stash it somewhere in drivers/input. Presumably it's
    > > possible to get it to link into the kernel even when INPUT is modular.
    >
    > Here's the patch, after spending some time to get familiar with git.
    >
    > The patch is against git x86/mm, and it seems to work fine on x86. However,
    > on x86, you no longer have /sys/devices/platform/pcspkr after
    > running "make allnoconfig". To get it, you have to explicitely add support
    > to CONFIG_INPUT_PCSPKR (m or y). I hope this is fine.
    >
    > I'm copying the MIPS maintainer as this patch touches his tree too.
    >
    > On MIPS, there should be no impact though, as CONFIG_PCSPEAKER is set in
    > defconfig files.
    >...

    The defconfig files do not set anything, they are just .config's you can
    use as a start for configuring your kernel.

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed



    \
     
     \ /
      Last update: 2008-01-24 18:15    [W:0.022 / U:29.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site