lkml.org 
[lkml]   [2008]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/17] [MIPS] Malta, Atlas, Sead: remove an extern from .c files
    Date
    This patch moves the "extern" declaration for the function
    mips_reboot_setup() from the board setup .c files to the
    header file include/asm-mips/mips-boards/generic.h.

    This fixes a warning produced by the checkpatch.pl script.

    No functional changes introduced.

    This was compile-tested by building the kernel for all
    three boards affected by this change. All builds finished
    successfully.

    Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
    ---
    arch/mips/mips-boards/atlas/atlas_setup.c | 2 --
    arch/mips/mips-boards/malta/malta_setup.c | 2 --
    arch/mips/mips-boards/sead/sead_setup.c | 2 --
    include/asm-mips/mips-boards/generic.h | 2 ++
    4 files changed, 2 insertions(+), 6 deletions(-)

    diff --git a/arch/mips/mips-boards/atlas/atlas_setup.c b/arch/mips/mips-boards/atlas/atlas_setup.c
    index e405d11..5ce8004 100644
    --- a/arch/mips/mips-boards/atlas/atlas_setup.c
    +++ b/arch/mips/mips-boards/atlas/atlas_setup.c
    @@ -34,8 +34,6 @@
    #include <asm/time.h>
    #include <asm/traps.h>

    -extern void mips_reboot_setup(void);
    -
    #ifdef CONFIG_KGDB
    extern void kgdb_config(void);
    #endif
    diff --git a/arch/mips/mips-boards/malta/malta_setup.c b/arch/mips/mips-boards/malta/malta_setup.c
    index 480521f..e5ac079 100644
    --- a/arch/mips/mips-boards/malta/malta_setup.c
    +++ b/arch/mips/mips-boards/malta/malta_setup.c
    @@ -35,8 +35,6 @@
    #include <linux/console.h>
    #endif

    -extern void mips_reboot_setup(void);
    -
    #ifdef CONFIG_KGDB
    extern void kgdb_config(void);
    #endif
    diff --git a/arch/mips/mips-boards/sead/sead_setup.c b/arch/mips/mips-boards/sead/sead_setup.c
    index 1fb61b8..8aa8e5b 100644
    --- a/arch/mips/mips-boards/sead/sead_setup.c
    +++ b/arch/mips/mips-boards/sead/sead_setup.c
    @@ -34,8 +34,6 @@
    #include <asm/mips-boards/seadint.h>
    #include <asm/time.h>

    -extern void mips_reboot_setup(void);
    -
    static void __init serial_init(void);

    const char *get_system_type(void)
    diff --git a/include/asm-mips/mips-boards/generic.h b/include/asm-mips/mips-boards/generic.h
    index d589774..2ca6bda 100644
    --- a/include/asm-mips/mips-boards/generic.h
    +++ b/include/asm-mips/mips-boards/generic.h
    @@ -97,6 +97,8 @@ extern int mips_revision_corid;

    extern int mips_revision_sconid;

    +extern void mips_reboot_setup(void);
    +
    #ifdef CONFIG_PCI
    extern void mips_pcibios_init(void);
    #else
    --
    1.5.3


    \
     
     \ /
      Last update: 2008-01-24 17:57    [W:0.028 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site