lkml.org 
[lkml]   [2008]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 24/49] ext4: add block bitmap validation
    > On Mon, 21 Jan 2008 22:02:03 -0500 "Theodore Ts'o" <tytso@MIT.EDU> wrote:
    > + if (bh_submit_read(bh) < 0) {
    > + brelse(bh);
    > + ext4_error(sb, __FUNCTION__,
    > "Cannot read block bitmap - "
    > - "block_group = %lu, block_bitmap = %llu",
    > - block_group, bitmap_blk);
    > + "block_group = %d, block_bitmap = %llu",
    > + (int)block_group, (unsigned long long)bitmap_blk);
    > + return NULL;
    > + }
    > + if (!ext4_valid_block_bitmap(sb, desc, block_group, bh)) {
    > + brelse(bh);
    > + return NULL;
    > + }

    brelse() should only be used when the bh might be NULL - put_bh()
    can be used here.

    Please review all ext4/jbd2 code for this trivial speedup.


    \
     
     \ /
      Last update: 2008-01-23 23:11    [W:0.020 / U:123.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site