| Date | Tue, 22 Jan 2008 05:01:23 -0500 | | From | Jeff Garzik <> | | Subject | Re: [PATCH 19/26] atl1: modernize down/up functions |
| |
jacliburn@bellsouth.net wrote: > From: Jay Cliburn <jacliburn@bellsouth.net> > > Update atl1_down() and atl1_up() to conform with the current vendor driver > version 1.2.40.2. > > Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net> > --- > drivers/net/atlx/atl1.c | 21 ++++++++------------- > drivers/net/atlx/atl1.h | 1 - > drivers/net/atlx/atlx.c | 2 +- > 3 files changed, 9 insertions(+), 15 deletions(-)
same comments continue... these are software changes that need to be explained.
"conform with vendor driver" does not excuse failure to document changes in init and shutdown sequencing, for example.
|