Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin | Date | Wed, 23 Jan 2008 12:54:26 +1100 |
| |
On Wednesday 23 January 2008 10:13:37 Jan Engelhardt wrote: > On Jan 21 2008 22:16, Rusty Russell wrote: > >On Monday 21 January 2008 20:08:25 Denis Cheng wrote: > >> the original code use KOBJ_NAME_LEN for built-in module name length, > >> that's defined to 20 in linux/kobject.h, but this is not enough > >> appearntly, many module names are longer than this; > >> #define KOBJ_NAME_LEN 20 > > > >Thanks, applied. I was surprisedto learn that we have a 35-char source > >filename in the kernel. > > > >And congratulations to nf_conntrack_l3proto_ipv4_compat.c! > > But nf..dada_compat.c gets linked into nf_conntrack_ipv4.ko, > and that is what is used in /sys/module - and it fits the 20. > Any place where nf_conntrack_l3proto_ipv4_compat would still be used?
Of course, but my point was that we already have a 35 char filename in the kernel, and lots of > 22 chars, so increasing it is not unreasonable.
FYI make allmodconfig here gives me the following of 21 chars or longer:
dvb-usb-af9005-remote dvb-usb-dibusb-common nf_conntrack_netbios_ns nf_conntrack_proto_udplite nf_conntrack_proto_sctp nf_conntrack_proto_gre
Cheers, Rusty.
| |