[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] ppc: fix #ifdef-s in mediabay driver

    On Wed, 2008-01-23 at 00:12 +0100, Bartlomiej Zolnierkiewicz wrote:
    > * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
    > check_media_bay() by CONFIG_MAC_FLOPPY one.
    > * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef-s by
    > * check_media_bay() is used only by drivers/block/swim3.c
    > so make this function available only if CONFIG_MAC_FLOPPY
    > is defined.
    > * check_media_bay_by_base() and media_bay_set_ide_infos()
    > are used only by drivers/ide/ppc/pmac.c so so make these
    > functions available only if CONFIG_MAC_FLOPPY is defined.
    > Signed-off-by: Bartlomiej Zolnierkiewicz <>
    > ---
    > Ben, IMO this patch is safe for 2.6.24 (assuming that it builds fine :),
    > otherwise I would like to ask for permission to merge it through IDE
    > tree since I have other pending IDE patches depending on this one.

    I'd rather avoid touching 2.6.24 unless it actually fixes a bug or

    I'm tempted to actually remove all ifdef's ... if you have a media-bay,
    then there are about 99% chances it contains an IDE device, with the
    remaining percent being split with putting a floppy or a battery in. I
    doubt anybody will care building a kernel without the support for these
    and with the mediabay support, and still want to save a handful of bytes
    in that driver.


     \ /
      Last update: 2008-01-23 01:03    [W:0.083 / U:11.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site