lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] printk: implement printk_header() and merging printk, take #2
Jan Engelhardt wrote:
> On Jan 21 2008 05:48, Matthew Wilcox wrote:
>> On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote:
>>> In a nutshell, printk_header() lets you do the following atomically
>>> (against other messages).
>>>
>>> code:
>>> printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n");
>>>
>>> output:
>>> <6>ata1.00: line0
>>> <6> line1
>>> <6> line2
>> I think this is a really bad idea. It's much better to have:
>>
>> <6>ata1.00: line0
>> <6>ata1.00: line1
>> <6>ata1.00: line2
>>
>> That way you can grep for ata1.00 and get all messages relevant to that
>> device.
>
> Agreed, I too prefer <6>ata1.00 on every line.

What do you think about the second suggestion then?

ata1.00: line0
ata1.00 line1
ata1.00 line2

It allows you to grab for the header && has indication for message
boundaries.

--
tejun


\
 
 \ /
  Last update: 2008-01-23 00:55    [from the cache]
©2003-2011 Jasper Spaans