lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sched: don't take a mutex from interrupt context
    On Tue, Jan 22, 2008 at 05:25:38PM +0100, Peter Zijlstra wrote:
    > @@ -1428,9 +1428,9 @@ static void print_cfs_stats(struct seq_f
    > #ifdef CONFIG_FAIR_GROUP_SCHED
    > print_cfs_rq(m, cpu, &cpu_rq(cpu)->cfs);
    > #endif
    > - lock_task_group_list();
    > + rcu_read_lock();
    > for_each_leaf_cfs_rq(cpu_rq(cpu), cfs_rq)
    > print_cfs_rq(m, cpu, cfs_rq);

    Isn't there a possibility that print_cfs_rq() can block?

    > - unlock_task_group_list();
    > + rcu_read_unlock();
    > }
    > #endif
    >

    --
    Regards,
    vatsa


    \
     
     \ /
      Last update: 2008-01-22 17:41    [W:0.021 / U:63.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site