Messages in this thread | | | Date | Tue, 22 Jan 2008 16:12:34 +0200 | From | Avi Kivity <> | Subject | Re: [kvm-devel] [PATCH] mmu notifiers #v3 |
| |
Andrea Arcangeli wrote: > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -44,8 +44,10 @@ > ({ \ > int __young; \ > __young = ptep_test_and_clear_young(__vma, __address, __ptep); \ > - if (__young) \ > + if (__young) { \ > flush_tlb_page(__vma, __address); \ > + mmu_notifier(age_page, (__vma)->vm_mm, __address); \ > + } \ > __young; \ > }) >
I think that unconditionally doing
__young |= mmu_notifier(test_and_clear_young, ...);
allows hardware with accessed bits more control over what is going on.
-- error compiling committee.c: too many arguments to function
| |