lkml.org 
[lkml]   [2008]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 52/58] [GFS2] Remove unneeded i_spin
    Date
    From: Bob Peterson <rpeterso@redhat.com>

    This patch removes a vestigial variable "i_spin" from the gfs2_inode
    structure. This not only saves us memory (>300000 of these in memory
    for the oom test) it also saves us time because we don't have to
    spend time initializing it (i.e. slightly better performance).

    Signed-off-by: Bob Peterson <rpeterso@redhat.com>
    Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

    diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
    index bd92a6d..1339996 100644
    --- a/fs/gfs2/incore.h
    +++ b/fs/gfs2/incore.h
    @@ -267,7 +267,6 @@ struct gfs2_inode {
    struct gfs2_alloc *i_alloc;
    u64 i_last_rg_alloc;

    - spinlock_t i_spin;
    struct rw_semaphore i_rw_mutex;
    };

    diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
    index 88686fc..9c7765c 100644
    --- a/fs/gfs2/main.c
    +++ b/fs/gfs2/main.c
    @@ -29,7 +29,6 @@ static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo)
    struct gfs2_inode *ip = foo;

    inode_init_once(&ip->i_inode);
    - spin_lock_init(&ip->i_spin);
    init_rwsem(&ip->i_rw_mutex);
    ip->i_alloc = NULL;
    }
    --
    1.5.1.2


    \
     
     \ /
      Last update: 2008-01-21 11:25    [W:4.553 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site