lkml.org 
[lkml]   [2008]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/10] introduce intel_menlow platform specific driver
On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> From: Thomas Sujith <sujith.thomas@intel.com>
>
> Intel menlow platform specific driver for thermal management.
>
> Signed-off-by: Thomas Sujith <sujith.thomas@intel.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
> drivers/misc/Kconfig | 10
> drivers/misc/Makefile | 1
> drivers/misc/intel_menlow.c | 527 ++++++++++++++++++++++++++++++++++++++++++++

Why is this in drivers/misc? I don't have a thermal.h in mainline, but
if this is a new subsystem your adding care to create a directory under
drivers/ for it?

> +/*
> +* intel_menlow.c - Intel menlow Driver for thermal management extension
> +*
> +* Copyright (C) 2008 Intel Corp
> +* Copyright (C) 2008 Sujith Thomas <sujith.thomas@intel.com>
> +* Copyright (C) 2008 Zhang Rui <rui.zhang@intel.com>

Please add a whitespace before the * so they line up.

> +MODULE_AUTHOR("Thomas Sujith");
> +MODULE_AUTHOR("Zhang Rui");

I've never seen a driver with two MODULE_AUTHOR statements before. Does
this actually work? What does modinfo -F author say for your module?



\
 
 \ /
  Last update: 2008-01-21 10:57    [W:1.766 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site