Messages in this thread | | | Date | Tue, 22 Jan 2008 04:57:19 +0300 | From | "Anton Salikhmetov" <> | Subject | Re: [PATCH -v7 2/2] Update ctime and mtime for memory-mapped files |
| |
2008/1/22, Jesper Juhl <jesper.juhl@gmail.com>: > On 22/01/2008, Anton Salikhmetov <salikhmetov@gmail.com> wrote: > > 2008/1/22, Jesper Juhl <jesper.juhl@gmail.com>: > > > Some very pedantic nitpicking below; > > > > > > On 22/01/2008, Anton Salikhmetov <salikhmetov@gmail.com> wrote: > ... > > > > + if (file && (vma->vm_flags & VM_SHARED)) { > > > > + if (flags & MS_ASYNC) > > > > + vma_wrprotect(vma); > > > > + if (flags & MS_SYNC) { > > > > > > "else if" ?? > > > > The MS_ASYNC and MS_SYNC flags are mutually exclusive, that is why I > > did not use the "else-if" here. Moreover, this function itself checks > > that they never come together. > > > > I would say that them being mutually exclusive would be a reason *for* > using "else-if" here.
This check is performed by the sys_msync() function itself in its very beginning.
We don't need to check it later.
> > -- > Jesper Juhl <jesper.juhl@gmail.com> > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please http://www.expita.com/nomime.html >
| |