lkml.org 
[lkml]   [2008]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] Modules: Fold percpu_modcopy into module.c
David Miller wrote:
> From: travis@sgi.com
> Date: Fri, 18 Jan 2008 10:29:54 -0800
>
>> percpu_modcopy() is defined multiple times in arch files. However, the only
>> user is module.c. Put a static definition into module.c and remove
>> the definitions from the arch files.
>>
>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>> Cc: Andi Kleen <ak@suse.de>
>> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>> Signed-off-by: Mike Travis <travis@sgi.com>
>
> This doesn't build on sparc64.
>
> The percpu_modcopy() removal from include/asm-sparc64/percpu.h
> leaked into patch #3 instead of being done here in patch #1
> where it belongs (so that this series is properly bisectable).
>
> It also seems that the include/asm-x86/percpu_{32,64}.h defines
> aren't removed in this patch either.

Hi,

I think I have this fixed in the newest version. Yes, it's been
a hat dance with some changes coming through the git-x86 patch
and others not. I'll submit the new one shortly.

Thanks,
Mike


\
 
 \ /
  Last update: 2008-01-21 16:43    [W:0.082 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site