lkml.org 
[lkml]   [2008]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 9/10] introduce intel_menlow platform specific driver
Date
From


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Monday, January 21, 2008 3:24 PM
> To: Zhang, Rui
> Cc: lenb@kernel.org; linux-acpi@vger.kernel.org; linux-pm@lists.linux-
> foundation.org; linux-kernel@vger.kernel.org; Thomas, Sujith
> Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific
driver
>
> On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> > From: Thomas Sujith <sujith.thomas@intel.com>
> >
> > Intel menlow platform specific driver for thermal management.
> >
> > Signed-off-by: Thomas Sujith <sujith.thomas@intel.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> > drivers/misc/Kconfig | 10
> > drivers/misc/Makefile | 1
> > drivers/misc/intel_menlow.c | 527
> ++++++++++++++++++++++++++++++++++++++++++++
>
> Why is this in drivers/misc? I don't have a thermal.h in mainline,
but
> if this is a new subsystem your adding care to create a directory
under
> drivers/ for it?
This patch series adds a new "thermal" subsystem and is rightly placed
under drivers/thermal/ . intel_menlow.c isn't fully a thermal driver. It
does all the platform specific stuff (thermal is one of them). It's not
fitting under any of the subsystems hence moved to drivers/misc
>
> > +/*
> > +* intel_menlow.c - Intel menlow Driver for thermal management
> extension
> > +*
> > +* Copyright (C) 2008 Intel Corp
> > +* Copyright (C) 2008 Sujith Thomas <sujith.thomas@intel.com>
> > +* Copyright (C) 2008 Zhang Rui <rui.zhang@intel.com>
>
> Please add a whitespace before the * so they line up.
Will take care of this.
>
> > +MODULE_AUTHOR("Thomas Sujith");
> > +MODULE_AUTHOR("Zhang Rui");
>
> I've never seen a driver with two MODULE_AUTHOR statements before.
Does
> this actually work? What does modinfo -F author say for your module?
There is nothing wrong in giving 2 MODULE_AUTHORS. Both will be
displayed in the command modinfo -F author.

:-Sujith



\
 
 \ /
  Last update: 2008-01-21 15:23    [W:0.197 / U:6.192 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site