Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] kbuild: introduce blacklisting in modpost | Date | Mon, 21 Jan 2008 12:00:15 +1100 |
| |
On Monday 21 January 2008 07:08:59 Sam Ravnborg wrote: > Change the logic in modpost so we identify all the > bad combinations of sections that refer to other > sections. ... > +/* The pattern is an array of simple patterns. > + * "foo" will match an exact string equal to "foo" > + * "foo*" will match a string that begins with "foo" > + * "foo$" will match a string equal to "foo" or "foo.1" > + * where the '1' can be any number including several digits. > + * The $ syntax is for sections where ld append a dot number > + * to make section name unique.
Dumb question: would it be easier to canonicalize all the section names by removing trailing .[num]*, then using fnmatch() and standard wildcards?
The rest of the patches look really nice: thanks for doing this cleanup!
Rusty.
| |