lkml.org 
[lkml]   [2008]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: kprobes change kprobe_handler flow

* Abhishek Sagar <sagar.abhishek@gmail.com> wrote:

> > > + default:
> > > + /* impossible cases */
> > > + BUG();
> >
> > I think no need to check that here.
>
> It may not get hit at runtime but is quite informative.

sidenote: please use WARN_ON(1) instead. In the case of the impossible
triggering somehow (the Linux kernel is notorious for that ;-), we'd
have a nice WARN_ON(1) in the dmesg, instead of a crashed box.

Ingo


\
 
 \ /
  Last update: 2008-01-02 21:27    [from the cache]
©2003-2011 Jasper Spaans