lkml.org 
[lkml]   [2008]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6.24 patch] Fix blackfin HARDWARE_PM support
    * Mathieu Desnoyers (mathieu.desnoyers@polymtl.ca) wrote:
    > (Robin, can you check if this patch does what is currently intended with
    > HARDWARE_PM please ? This involves testing with CONFIG_OPROFILE y/m/n.)
    >
    > This patch restores the blackfin Hardware Performance Monitor Profiling
    > support that was killed by
    > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
    >
    > Since there seems to be no good reason to behave differently from other
    > architectures, it now automatically selects the hardware performance counters
    > whenever the profiling is activated.
    >
    > mach-common/irqpanic.c: pm_overflow
    > calls pm_overflow_handler which is in oprofile/op_model_bf533.c. I doubt that
    > setting HARDWARE_PM as "m" will work at all, since the pm_overflow_handler
    > should be in the core kernel image because it is called by irqpanic.c.
    >
    > Therefore, I change HARDWARE_PM from a tristate to a bool.
    >
    > The whole arch/$(ARCH)/oprofile/ is built depending on CONFIG_OPROFILE. Since
    > part of the HARDWARE_PM support files sits in this directory, it makes sense to
    > also depend on OPROFILE, not only PROFILING. Since OPROFILE already depends on
    > PROFILING, it is correct to only depend on OPROFILE only.
    >


    This patch header should also include :

    Problem identified by Adrian Bunk. Patch inspired by the original fix
    proposed by him.

    Thanks,

    Mathieu


    > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    > CC: Adrian Bunk <adrian.bunk@movial.fi>
    > CC: Randy Dunlap <randy.dunlap@oracle.com>
    > CC: bryan.wu@analog.com
    > CC: Robin Getz <rgetz@blackfin.uclinux.org>
    > ---
    > arch/blackfin/Kconfig | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > Index: linux-2.6-lttng/arch/blackfin/Kconfig
    > ===================================================================
    > --- linux-2.6-lttng.orig/arch/blackfin/Kconfig 2007-12-29 11:00:05.000000000 -0500
    > +++ linux-2.6-lttng/arch/blackfin/Kconfig 2007-12-29 11:25:39.000000000 -0500
    > @@ -65,6 +65,10 @@ config GENERIC_CALIBRATE_DELAY
    > bool
    > default y
    >
    > +config HARDWARE_PM
    > + def_bool y
    > + depends on OPROFILE
    > +
    > source "init/Kconfig"
    > source "kernel/Kconfig.preempt"
    >
    >
    > --
    > Mathieu Desnoyers
    > Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
    > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >

    --
    Mathieu Desnoyers
    Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


    \
     
     \ /
      Last update: 2008-01-02 18:55    [W:3.111 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site