Messages in this thread | | | Date | Sat, 19 Jan 2008 21:55:07 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] Core driver for WM97xx touchscreens |
| |
On Sat, Jan 19, 2008 at 10:48:32PM +0300, Dmitry wrote:
> Well... It's a common suggestion not to duplicate code. The wm97xx bus > looks mostly like platform. The only difference is the name. To help > visualisation, devices can have parents. Just set (in pseudocode) > wm97xx-touchscreen->parent to wm97xx, do the same for wm97xx-battery > and so on. Thus all devices would be on the platform device but with > proper parent <-> child notation.
That's exactly what I had understood you to mean. I guess it's just that using the platform bus for this purpose feels like an abstraction violation to me due to having platform devices parented off a device on another bus. Obviously it's just my model of a platform device that's wrong here. I will change the driver to use the platform bus for my next submission.
> git://git.mnementh.co.uk/linux-2.6-im.git#tmio_dev_try3. Look for
Thanks, I'll take a look.
> 2008/1/19, Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > current patch series these chips all also provide an audio codec which > > requires a reasonably substantial driver for full support.
> This would only touch child devices organisation.
Indeed - I mention it mostly for additional motivation.
| |