Messages in this thread | | | Date | Sat, 19 Jan 2008 03:42:00 +0100 | From | Andi Kleen <> | Subject | Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text |
| |
> > I think it should be enabled on AMD too though. If the reordering breaks > > it then blacklisting won't help anyways.
Actually it is already enabled on AMD. You check for is_cpu(INTEL) but that just checks the generic MTRR architecture and all AMD CPUs since K7 use that one too.
That is ok imho.
Perhaps it would be good to fix the incorrect comment though.
> > > > -Andi > > > > [1] but I checked the known errata and there was nothing related to MTRR. > > Ah, ok, that explains your reticence earlier. Thanks for testing again, I > guess the patch is good to go.
I see a failure here now on a (AMD) system where it trims a lot of memory, but should probably not (or at least i haven't noticed any malfunction before without it). Investigating.
-Andi
| |