Messages in this thread | | | Date | Fri, 18 Jan 2008 18:33:19 +0100 | From | Jochen Friedrich <> | Subject | Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver. |
| |
Scott Wood schrieb:
>> +void watchdog_poke(void) >> +{ >> + if (wdt) { >> + out_be16(&wdt->swsrr, 0x556c); >> + out_be16(&wdt->swsrr, 0xaa39); >> + } >> +} > > This should be a function pointer, to allow for other watchdog types.
Thanks for the comments. Stephen Rothwell also asked if the filename watchdog.c is too generic. I think the pq watchdog is easy enough to keep it in the generic watchdog.c file, but the function pointer definitely is the way to go. I'll resubmit.
Thanks, Jochen
| |