lkml.org 
[lkml]   [2008]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling

* Matt Mackall <mpm@selenic.com> wrote:

> > I can propose a corresponding patch, and I'd suggest to make
> > CONFIG_PCSPEAKER depend on CONFIG_EMBEDDED.
>
> No, don't. It's fine the way it is. If INPUT_PCSPKR isn't set, we
> don't support the speaker, end of story.

yeah.

> Also, bear in mind that there is a fair amount of lower-hanging fruit
> than this, so bouncing a bunch of patches back and forth to make this
> perfect is not the best use of people's time.

as long as it's arch/x86 stuff i can pick up patches no problem.

[ Sidenote: "too small" and "too insignificant" is not a patch attribute
that is in my vocabulary - by definition the best patches are very
small and very insignificant (they just happen to end up doing
something cool a 1000 steps later ;-) 99% of our problems come from
'too large' and 'too intrusive' patches. ]

Ingo


\
 
 \ /
  Last update: 2008-01-18 14:59    [from the cache]
©2003-2011 Jasper Spaans