lkml.org 
[lkml]   [2008]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Convert EXT2 to use unlocked_ioctl
Date
On Thursday 17 January 2008, you wrote:
>
> Change ext_ioctl() to be an unlocked_ioctl(), explicitly
> exposing BKL's uses.
>
> Signed-off-by: Mathieu Segaud <mathieu.segaud@regala.cx>

You are now calling lock_kernel() twice in case of ext2_compat_ioctl(),
which calls back into ext2_ioctl with the BKL already held.

This is allowed with the BKL, but really bad style that you should
avoid. I assume the ext3 and ext4dev versions of your patch have
the same issue, but I didn't check in detail.

Arnd <><


\
 
 \ /
  Last update: 2008-01-17 12:57    [W:0.130 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site