Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] Convert EXT2 to use unlocked_ioctl | Date | Thu, 17 Jan 2008 12:54:03 +0100 |
| |
On Thursday 17 January 2008, you wrote: > > Change ext_ioctl() to be an unlocked_ioctl(), explicitly > exposing BKL's uses. > > Signed-off-by: Mathieu Segaud <mathieu.segaud@regala.cx>
You are now calling lock_kernel() twice in case of ext2_compat_ioctl(), which calls back into ext2_ioctl with the BKL already held.
This is allowed with the BKL, but really bad style that you should avoid. I assume the ext3 and ext4dev versions of your patch have the same issue, but I didn't check in detail.
Arnd <><
| |