Messages in this thread | | | From | Len Brown <> | Subject | Re: [PATCH 9/10] introduce intel_menlow platform specific driver | Date | Thu, 17 Jan 2008 14:51:18 -0500 |
| |
> > +static int > > +memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev, > > + unsigned long *max_state) > > Don't put 'static int' (return type etc.) on a line by itself. > That format is not wanted in Linux. (many places here)
if checkpatch.pl and Lindent are happey (which they are not, totally) then I'm satisifed witht he Linux style of the code.
Randy, if you feel strongly about this this style nit, then change Lindent to implement it -- nagging developers about trivia is a waste of everybody's time.
thanks, -Len
| |