lkml.org 
[lkml]   [2008]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.24-rc8-mm1 Build Failure on scsi driver
    On Thu, 17 Jan 2008 21:45:39 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:

    > Hi Andrew,
    >
    > The kernel build fails with following error
    >
    > drivers/scsi/aha152x.o: In function `aha152x_host_reset_host':
    > /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: multiple definition of `aha152x_host_reset_host'
    > drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: first defined here
    > drivers/scsi/aha152x.o: In function `aha152x_release':
    > /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908: multiple definition of `aha152x_release'
    > drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908: first defined here
    > ld: Warning: size of symbol `aha152x_release' changed from 68 in drivers/scsi/pcmcia/built-in.o to 100 in drivers/scsi/aha152x.o
    > drivers/scsi/aha152x.o: In function `aha152x_probe_one':

    Neat. Seems that the scsi build system is linking together two copies of
    drivers/scsi/aha152x.o. One via drivers/scsi/aha152x.o directly and the
    other via drivers/scsi/pcmcia/built-in.o.

    Please send the .config.

    I'm looking suspiciously at this, from git-scsi-misc:

    commit 8ae732a91df051aba6820068a47b631a06599d84
    Author: Tejun Heo <htejun@gmail.com>
    Date: Fri Dec 7 22:36:23 2007 +0900

    [SCSI] make pcmcia directory use obj-y|m instead of subdir-y|m

    subdir-y|m isn't supposed to contain modules or built-in components.
    Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA).

    Signed-off-by: Tejun Heo <htejun@gmail.com>
    Acked-by: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

    diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
    index b5441f5..93e1428 100644
    --- a/drivers/scsi/Makefile
    +++ b/drivers/scsi/Makefile
    @@ -17,7 +17,7 @@
    CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF
    CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS

    -subdir-$(CONFIG_PCMCIA) += pcmcia
    +obj-$(CONFIG_PCMCIA) += pcmcia/

    obj-$(CONFIG_SCSI) += scsi_mod.o
    obj-$(CONFIG_SCSI_TGT) += scsi_tgt.o


    \
     
     \ /
      Last update: 2008-01-17 20:15    [W:0.024 / U:2.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site