Messages in this thread | | | Date | Wed, 16 Jan 2008 12:41:50 +0800 | From | "Dave Young" <> | Subject | Re: [PATCH for 2.6.24] fix workqueue creation API lockdep interaction |
| |
On Jan 15, 2008 9:04 PM, Johannes Berg <johannes@sipsolutions.net> wrote: > Dave Young reported warnings from lockdep that the workqueue API > can sometimes try to register lockdep classes with the same key > but different names. This is not permitted in lockdep. > > Unfortunately, I was unaware of that restriction when I wrote > the code to debug workqueue problems with lockdep and used the > workqueue name as the lockdep class name. This can obviously > lead to the problem if the workqueue name is dynamic. > > This patch solves the problem by always using a constant name > for the workqueue's lockdep class, namely either the constant > name that was passed in or a string consisting of the variable > name. > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net> > --- > Please be careful with this patch, I haven't been able to test it so far > because my powerbook doesn't have lockdep.
Hi, Just for confirm, the warnings didn't trigger after applied your patch, thanks.
Regards dave
| |