Messages in this thread | | | Date | Tue, 15 Jan 2008 22:22:23 -0500 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c |
| |
Kyle McMartin wrote: > On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote: >> +#ifdef CONFIG_X86_F00F_BUG >> +void do_invalid_op(struct pt_regs *, unsigned long); >> +#endif >> + >> +static int is_f00f_bug(struct pt_regs *regs, unsigned long address) >> +{ >> +#ifdef CONFIG_X86_F00F_BUG >> + unsigned long nr; > > You can just put the prototype inside the function, you know...
You can also make the prototype unconditional, even if the function doesn't necessarily exist.
-hpa
| |