Messages in this thread | | | Date | Wed, 16 Jan 2008 11:58:37 +0900 | From | Tejun Heo <> | Subject | Re: [PATCHSET] printk: implement printk_header() and merging printk |
| |
Hello,
Randy Dunlap wrote: >> mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0); >> mprintk_push(&mp, "ATA %d", 7); >> mprintk_push(&mp, ", %u sectors\n", 1024); >> mprintk(&mp, "everything seems dandy\n"); > > Looks pretty good to me except that I would change mprintk_push to > mprintk_add or mprintk_append (I think that I prefer _add).
I think push and flush sound good when used together but then again the flush function isn't visible in the interface and push has LIFO ring to it. I'm okay with add. append seems a bit too long.
Thanks.
-- tejun
| |