| Date | Tue, 15 Jan 2008 09:11:44 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] [0/31] Great change_page_attr patch series v2 |
| |
>>> Andi Kleen <ak@suse.de> 14.01.08 23:16 >>> > >Lots of improvements to change_page_attr(). Make it a lot more >efficient and fix various bugs. > >Changes against earlier version > >- Fixed some checkpatch.pl complaints >- Improved self test suite >- Fixed more reference bugs >- Fix NX handling on 32bit >- Remove some useless code there >- Few other random fixes
The one concept that I'm missing (but that I can easily produce a follow-up patch for, as I had this in my c_p_a() changes) is the tracking and adjusting of the reference protection for a large page range that got fully converted to another type (namely relevant for .rodata if it exceeds 2/4 Mb), allowing to use a large page mapping in this case even for non-default mappings.
Apart from the other comments, the whole series
Acked-by: Jan Beulich <jbeulich@novell.com>
|