lkml.org 
[lkml]   [2008]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Make checkpatch.pl's quiet option not print the summary on no errors
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote:
> Subject: Make checkpatch.pl's quiet option not print the summary on no
> errors
> From: Arjan van de Ven <arjan@linux.intel.com>
> CC: apw@uk.ibm.com
>
> Right now, in quiet mode, checkpatch.pl still prints a summary line even
> if the patch is 100% clean. IMO, "quiet mode" should mean "no output if
> clean",
> the patch below makes that so. (This also makes the quilt integration
> on my system work nicer :)
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

While looking to integrate this I discovered that the current default
was a desired feature requested by Ingo. So I guess we need to come up
with a combination of options which give us both.

Currently we have --[no-]summary meaning suppress/add a summary, and
--quiet meaning suppress output but which does not suppress the summary.

We have a few options:

1) allow doubling of -q to make the summary subject to -q,
2) allow doubling of --summary to mean "override -q", --summary becoming
subject to -q,
3) add a new option --force-summary which always produces a summary,
--summary becoming subject to -q, and
4) add a new option --summary-on-fail which is subject to -q.

I feel the last of these is the most obvious option, and carries
no modification to current semantics.

Thoughts?

-apw


\
 
 \ /
  Last update: 2008-01-15 21:13    [W:0.065 / U:1.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site