On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote:> Notice that error is already -EINVAL, so a simple goto should suffice.Yes, for the start of the function you can basically leave it as-is.