[lkml]   [2008]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86_64: checking aperture report for node instead of cpu

* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> - printk(KERN_INFO "CPU %d: aperture @ %Lx size %u MB\n",
> - num-24, aper_base, aper_size>>20);
> + printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n",
> + node++, aper_base, aper_size >> 20);

please dont put side-effects into printks. (put the node++ iteration out
into a separate line) Your patch looks fine otherwise.


 \ /
  Last update: 2008-01-15 14:25    [from the cache]
©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site