Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe() | Date | Sat, 12 Jan 2008 21:18:01 +0100 |
| |
On Friday 11 January 2008, Borislav Petkov wrote: > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> > --- > drivers/ide/ide-floppy.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c > index 89b26ea..0729df5 100644 > --- a/drivers/ide/ide-floppy.c > +++ b/drivers/ide/ide-floppy.c > @@ -1737,7 +1737,8 @@ static int ide_floppy_probe(ide_drive_t *drive) > " emulation.\n", drive->name); > goto failed; > } > - if ((floppy = kzalloc(sizeof (idefloppy_floppy_t), GFP_KERNEL)) == NULL) { > + floppy = kzalloc(sizeof(idefloppy_floppy_t), GFP_KERNEL); > + if (!floppy) { > printk(KERN_ERR "ide-floppy: %s: Can't allocate a floppy" > " structure\n", drive->name); > goto failed;
I'm unable to see any problem with error handling here?
This change should be combined with the rest of checkpatch.pl fixes.
| |