lkml.org 
[lkml]   [2008]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC, PATCH] watchdog on gpio
    Date
    Hello Marc,

    Your patch looks good to me, and I have been waiting for something like
    this :). Other comments below.

    Le jeudi 10 janvier 2008, Marc Pignat a écrit :
    > +#include <asm/uaccess.h>
    > +#include <asm/arch/gpio.h>

    At first sight, this will only work with the platforms which have implemented
    gpiolib, some (like MIPS) still use the old generic GPIO API. So I think the
    include will not work here for anything than ARM, correct me if I am wrong.

    > +static int gpio_wdt_keepalive(struct gpio_wdt *wdt)
    > +{
    > + gpio_set_value(wdt->pdata->pin, 0);
    > + gpio_set_value(wdt->pdata->pin, 1);
    > + return 0;
    > +}

    Some watchdog drivers requires you to toggle the full GPIO line, not only one
    bit (I particularly think about the MTX-1 board watchdog).

    Did you look into hooking into Wim's uniform watchdog driver :

    http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-experimental.git;a=commit;h=732c54027e6c866f98857c4a6d1c6c466459dcd5

    Maybe you can save some code ?



    --
    Cordialement, Florian Fainelli
    ------------------------------
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-01-11 18:03    [W:7.851 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site