lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/5] Intro: convert lockd to kthread and fix use-after-free (try #7)
On Thursday January 10, jlayton@redhat.com wrote:
> This is the seventh patchset to fix the use-after-free problem in lockd
....

This patch set looks good now. I'm happy to give it a

Reviewed-by: NeilBrown <neilb@suse.de>

Two remaining issues that I would like to see address, but don't
necessarily need to be part of this set, are:

1/ When the last nfsd thread dies, lockd should drop all locks, even
if there are active nfs mounts.
One approach might be:
export nlmsvc_invalidate_all
call it from nfsd_last_thread
worry about how to change grace_period_expire.

2/ get rid of svc_wake_up and ->b_daemon
Maybe change b_daemon to b_rqstp and just call
wake_up(&block->b_rqstp->rq_wait)

Thanks,
NeilBrown




\
 
 \ /
  Last update: 2008-01-11 02:39    [W:0.070 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site