lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/16] udf: fix udf_debug macro
    On Thu 10-01-08 23:06:31, marcin.slusarz@gmail.com wrote:
    > udf_debug should be enclosed with do { } while (0)
    > to be safely used in code like below:
    > if (something)
    > udf_debug();
    > else
    > anything;
    > (Otherwise compiler will not compile it with:
    > "error: expected expression before 'else'")
    >
    > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
    > CC: Jan Kara <jack@suse.cz>
    > ---
    > include/linux/udf_fs.h | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/include/linux/udf_fs.h b/include/linux/udf_fs.h
    > index 36c684e..c954527 100644
    > --- a/include/linux/udf_fs.h
    > +++ b/include/linux/udf_fs.h
    > @@ -39,11 +39,11 @@
    >
    > #ifdef UDFFS_DEBUG
    > #define udf_debug(f, a...) \
    > - { \
    > + do { \
    > printk (KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
    > __FILE__, __LINE__, __FUNCTION__); \
    > printk (f, ##a); \
    > - }
    > + } while (0)
    > #else
    > #define udf_debug(f, a...) /**/
    > #endif
    Actually, in that case you should also change /**/ to
    do {} while (0)

    Honza
    --
    Jan Kara <jack@suse.cz>
    SUSE Labs, CR


    \
     
     \ /
      Last update: 2008-01-11 00:31    [W:0.022 / U:0.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site