Messages in this thread | | | Date | Thu, 10 Jan 2008 09:44:57 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH][RFC] fast file mapping for loop |
| |
On Thu, Jan 10 2008, Christoph Hellwig wrote: > > > loop maintains a prio tree of known > > > extents in the file (populated lazily on demand, as needed). > > > > Just a quick question (I haven't looked closely at the code): how come > > you are using a prio tree for extents? I don't think they could be > > overlapping? > > IMHO this shouldn't be done in the loop driver anyway. Filesystems have > their own effricient extent lookup trees (well, at least xfs and btrfs > do), and we should leverage that instead of reinventing it.
Completely agree, it's just needed right now for this solution since all we have is a crappy bmap() interface to get at those mappings.
-- Jens Axboe
| |