Messages in this thread | | | Date | Thu, 10 Jan 2008 23:19:28 +0100 | From | Roel Kluin <> | Subject | Re: [PATCH wireless/arlan] Replace logical- by bit-and |
| |
Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h >> index 3ed1df7..7b7498f 100644 >> --- a/drivers/net/wireless/arlan.h >> +++ b/drivers/net/wireless/arlan.h >> @@ -485,7 +485,7 @@ struct arlan_private { >> #define clearClearInterrupt(dev){\ >> writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);} >> #define setPowerOff(dev){\ >> - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\ >> + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\ > > eh? How does that help?
Right, sorry, please ignore my patch.
> Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some > arlan developer or someone with specs should help here...
I have CC'd the previous maintainers
| |