Messages in this thread | | | Date | Thu, 10 Jan 2008 14:10:46 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [RFC PATCH 01/22 -v2] Add basic support for gcc profiler instrumentation |
| |
Hi Sam,
On Thu, 10 Jan 2008, Sam Ravnborg wrote:
> Hi Steven. > > > Index: linux-compile-i386.git/arch/x86/Kconfig > > =================================================================== > > --- linux-compile-i386.git.orig/arch/x86/Kconfig 2008-01-09 14:09:36.000000000 -0500 > > +++ linux-compile-i386.git/arch/x86/Kconfig 2008-01-09 14:10:07.000000000 -0500 > > @@ -28,6 +28,10 @@ config GENERIC_CMOS_UPDATE > > bool > > default y > > > > +config ARCH_HAS_MCOUNT > > + bool > > + default y > > + > > Please use the following scheme: > > arch/x86/Kconfig: > config X86 > + select HAVE_MCOUNT > > lib/tracing/Kconfig > > + # ARCH shall select HAVE_MCOUNT if they provide this function > + config HAVE_MCOUNT > + bool > + > + config MCOUNT > + bool > + select FRAME_POINTER > > And then in your later patches: > +config MCOUNT_TRACER > + bool "Profiler instrumentation based tracer" > + depends on DEBUG_KERNEL && HAVE_MCOUNT > + select MCOUNT > + help > + Use profiler....
Thanks, this does look like a cleaner approach. I'll implement it into my next series.
-- Steve
| |