lkml.org 
[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl
    > Really, all this is doing is open coding what the ioctl handler is doing
    > anyway, isn't it? in which case, why bother to change it at all?

    Because once it's open coded it is visible and can then be eliminated.
    Does SCSI need the BKL at all?

    But perhaps for such a long ioctl handler it would be better to move
    the lock/unlock_kernel()s into the individual case ...: statements;
    then it could be eliminated step by step.

    -Andi


    \
     
     \ /
      Last update: 2008-01-10 20:01    [W:0.029 / U:67.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site