Messages in this thread | | | Date | Thu, 10 Jan 2008 17:09:12 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU |
| |
On Thu, Jan 10, 2008 at 02:12:59PM +0100, Andi Kleen wrote: > Adrian Bunk <bunk@kernel.org> writes: > > > > Technically you are the one who has to deal with problems in your > > patches, not the people pointing at the problems. > > If you believe that my patch adds a new problem then please describe > it clearly so that I can understand it.
Description: - there are already __cpuinit* annotations in the kernel - on UP kernels supporting suspend/resume, such annotated code currently gets freed after booting (and this works) - with your patch applied, this code no longer gets freed
Whether or not this is a problem depends on whether you care about the memory used by the kernel or not...
My other issues with your patch were: - whatever warning this patch was supposed to fixed was not shown (the patch description didn't mention any warning at all) - and understanding a fix gets easier when you know the problem it's supposed to fix - this patch shouldn't be x86 specific since the issue how to annotate suspend and CPU hotplug code isn't x86 specific
> -Andi
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |