Messages in this thread | | | Date | Thu, 10 Jan 2008 06:06:50 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] x86: trivial whitespace in kprobes.c |
| |
Masami Hiramatsu wrote: > Harvey Harrison wrote: >> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> > > Acked-by: Masami Hiramatsu <mhiramat@redhat.com> > >> --- >> Ingo, you could/should probably fold this into Masami's kprobe >> unification patch. > > The original code had these whitespace, because (I think) > kretprobe_trampoline_holder() had just hold a memory space > for hooking function return. And now, it has actual code.
Hmm, this function still a bit special, because it is not called directly. kretprobe uses kretprobe_trampoline symbol, which is defined in this function. Anyway, I think the whitespace does not help us understand it...
> So the whitespace can be removed.
Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division
e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com
| |