Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles | Date | Tue, 01 Jan 2008 14:44:48 +0100 |
| |
Sam Ravnborg <sam@ravnborg.org> writes:
>> @@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \ >> -D TIMESTAMP=$(shell date +%s) >> >> $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE) >> - $(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $< >> + $(CC) -fno-pic $(HEAD_DEFINES) -I$(objtree)/include -c -o $@ $< > This has never worked with O=.. builds. > The correct fix here is to use: >> + $(CC) -fno-pic $(HEAD_DEFINES) -Iinclude -Iinclude2 -c -o $@ $< > > The -Iinclude2 is only for O=... builds so to keep current > behaviour removing $(TOPDIR)/ would do it.
Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)?
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |