lkml.org 
[lkml]   [2008]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID
    From
    Date
    On Wed, 2008-01-02 at 00:20 +0100, Pavel Machek wrote:
    > Hi!
    >
    > > /proc/acpi/wakeup is also case-sensitive, case-insensitive is better.
    >
    > Why?
    A user uses device bus id like 'C093' to enable or disable wakeup of the
    device, for example

    echo "C093" > /proc/acpi/wakeup

    but i think "c093" should also be ok. i.e.

    "echo 'c093' > /proc/acpi/wakeup" should have the same result as "echo
    'C093' > /proc/acpi/wakeup".

    That is to say, it should be case-insensitive.
    >
    > > In addtion, this patch appends a new column 'PCI ID' to /proc/acpi/wakeup
    > > , the user can use it to get the corresponding device name very
    > > conveniently because PCI ID is a unique identifier and platform-independent.
    >
    > Userland interface change...?
    Not at all, i didn't find any userland application
    assumes /proc/acpi/wakeup must be that kind of format.

    In fact, /proc output is always changing. :-)
    >
    > Maybe this file should be left for compatibility and we should present
    > something reasonable in /sys? Can't you already get PCI ID from sysfs
    > node?
    PCI ID can be gotten from sysfs, but it is a unique identifier for a
    device, a user can get device name from /usr/share/hwdata/pci.ids in any
    dstribution by PCI ID, he/she is unnecessary to use bus number to get
    device name, bus number is platform-specific, but PCI ID is
    platform-independent.

    > Pavel
    >
    > > [root@localhost ~]# cat /proc/acpi/wakeup
    > > Device S-state Status Sysfs node
    > > C093 S5 disabled pci:0000:00:1e.0
    > > C0E8 S3 disabled pci:0000:00:1d.0
    > > C0EF S3 disabled pci:0000:00:1d.1
    > > C0F0 S3 disabled pci:0000:00:1d.2
    > > C0F1 S3 disabled pci:0000:00:1d.3
    > > C0F2 S3 disabled pci:0000:00:1d.7
    > > C0F9 S0 disabled pci:0000:00:1c.0
    > > C21D S0 disabled pci:0000:08:00.0
    > > C109 S5 disabled pci:0000:00:1c.1
    > > C228 S5 disabled pci:0000:10:00.0
    > > C10F S5 disabled pci:0000:00:1c.3
    > > C229 S5 disabled
    > > [root@localhost ~]#
    > >
    > > After applying this patch, the output is:
    > >
    > > [root@localhost ~]# cat /proc/acpi/wakeup
    > > Device S-state Status Sysfs node PCI ID
    > > C093 S5 disabled pci:0000:00:1e.0 0x2448
    > > C0E8 S3 disabled pci:0000:00:1d.0 0x27c8
    > > C0EF S3 disabled pci:0000:00:1d.1 0x27c9
    > > C0F0 S3 disabled pci:0000:00:1d.2 0x27ca
    > > C0F1 S3 disabled pci:0000:00:1d.3 0x27cb
    > > C0F2 S3 disabled pci:0000:00:1d.7 0x27cc
    > > C0F9 S0 disabled pci:0000:00:1c.0 0x27d0
    > > C21D S0 disabled pci:0000:08:00.0 0x16fd
    > > C109 S5 disabled pci:0000:00:1c.1 0x27d2
    > > C228 S5 disabled pci:0000:10:00.0 0x4222
    > > C10F S5 disabled pci:0000:00:1c.3 0x27d6
    > > C229 S5 disabled
    >



    \
     
     \ /
      Last update: 2008-01-02 03:09    [W:0.027 / U:0.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site