lkml.org 
[lkml]   [2008]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles
    On Tue, Jan 01, 2008 at 03:41:05PM +0800, WANG Cong wrote:
    >
    > TOPDIR is obsolete, use objtree instead.
    > This patch removes TOPDIR from all fs/ Makefiles.
    >
    > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
    > Cc: Tim Shimmin <xfs-masters@oss.sgi.com>
    > Cc: Sam Ravnborg <sam@ravnborg.org>
    > Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
    >
    > ---
    >
    > diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile
    > index 6673ee8..9b5e92b 100644
    > --- a/fs/smbfs/Makefile
    > +++ b/fs/smbfs/Makefile
    > @@ -34,5 +34,5 @@ proto:
    > @echo >> proto2.h "struct sock;"
    > @echo >> proto2.h "struct statfs;"
    > @echo >> proto2.h ""
    > - cproto -E "gcc -E" -e -v -I $(TOPDIR)/include -DMAKING_PROTO -D__KERNEL__ $(SRC) >> proto2.h
    > + cproto -E "gcc -E" -e -v -I $(objtree)/include -DMAKING_PROTO -D__KERNEL__ $(SRC) >> proto2.h
    > mv proto2.h proto.h
    > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
    > index 49e3e7e..d1d3d49 100644
    > --- a/fs/xfs/Makefile
    > +++ b/fs/xfs/Makefile
    > @@ -1 +1 @@
    > -include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
    > +include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)

    The whole "Maintainer rules" part of this file should be deleted.
    I cannot see how it can be used anyway.

    Sam


    \
     
     \ /
      Last update: 2008-01-01 11:33    [W:4.104 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site