lkml.org 
[lkml]   [2007]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] remove asm/bitops.h includes
On Sun, Sep 09, 2007 at 10:04:25AM +0200, Andi Kleen wrote:
> Jiri Slaby <jirislaby@gmail.com> writes:
>
> > remove asm/bitops.h includes
> >
> > including asm/bitops directly may cause compile errors.
>
> When does it cause compile errors? It would be probably less
> intrusive to just fix that case.

In -mm, include/asm-generic/bitops/non-atomic.h requires stuff from
include/linux/bitops.h

And it's generally better to have all users consistently use the linux/
headers instead of some using the linux/ headers and some the asm/
headers.

> -Andi

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-09 16:23    [W:0.051 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site