Messages in this thread | | | Date | Sun, 9 Sep 2007 16:21:17 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH 1/2] remove asm/bitops.h includes |
| |
On Sun, Sep 09, 2007 at 10:04:25AM +0200, Andi Kleen wrote: > Jiri Slaby <jirislaby@gmail.com> writes: > > > remove asm/bitops.h includes > > > > including asm/bitops directly may cause compile errors. > > When does it cause compile errors? It would be probably less > intrusive to just fix that case.
In -mm, include/asm-generic/bitops/non-atomic.h requires stuff from include/linux/bitops.h
And it's generally better to have all users consistently use the linux/ headers instead of some using the linux/ headers and some the asm/ headers.
> -Andi
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |